PostgreSQL embedded: tests use system temp dir for installation #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrizzi <[email protected]>
|
@bobmcwhirter I haven't permissions to add you as reviewer but I would like to have your review please. |
bobmcwhirter
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating the failure in https://github.com/trustification/trustify/actions/runs/8234967143/job/22517985508?pr=40#step:9:33, it turned out it was related to multi tests concurrently extracting PostgreSQL to the same folder.
Installing tests to extract PostgreSQL in folder within the system temporary directory enables tests to be executed concurrently.
The drawback with this implementation is that
into_pathconsumesTempDirhence it won't be automatically deleted at the end of the test but considering the installation directory is within the system temporary directory, I think this could be considered acceptable in the context of tests execution.