Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't treat all possible query values as strings #163

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

jcrossley3
Copy link
Contributor

@jcrossley3 jcrossley3 commented Apr 15, 2024

The fields we currently use in our entities are now supported. If we introduce new types, we may need to expand the envalue fn.

We're also accepting some human-friendly date values now.

Fixes #156
Resolves #145

@ctron
Copy link
Contributor

ctron commented Apr 16, 2024

May I ask again, why are we spending time on re-solving all those problems?

I think this resolves trustification#145

Signed-off-by: Jim Crossley <[email protected]>
@jcrossley3
Copy link
Contributor Author

May I ask again, why are we spending time on re-solving all those problems?

No 😉

@jcrossley3 jcrossley3 marked this pull request as ready for review April 16, 2024 15:35
@bobmcwhirter bobmcwhirter added this pull request to the merge queue Apr 16, 2024
Merged via the queue into trustification:main with commit 7c0f54b Apr 16, 2024
4 checks passed
@jcrossley3 jcrossley3 deleted the issue-156 branch June 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying dates is broken
3 participants