Remove panicking path conversions #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path::from_bytes_with_nul_unchecked was a wrapper for CStr::from_bytes_with_nul_unchecked and Path::from_cstr_unchecked. Keeping the two methods separate clearly communicates the requirements and reduces the likelihood of unsound usage.
To avoid unintended panics and to make it clear which conversions can fail and which cannot, this patch changes all panicking Path/PathBuf conversions to return a Result instead. Fixes: #63
sosthene-nitrokey
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes all constructors and conversion traits for
PathandPathBufto be fallible (except forFrom<&Path> for PathBuf). It also adds explicit invariants to the path types and marks its functions as const where possible.Fixes: #63