Path: Add ordering comparison functions #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
path-ord
branch
6 times, most recently
from
2cb990b
to
77a45fa
Compare
sosthene-nitrokey
changed the title
robin-nitrokey
approved these changes
Feb 2, 2024
sosthene-nitrokey
force-pushed
the
path-ord
branch
3 times, most recently
from
fcbdf21
to
e8d646f
Compare
The ordering of path (as obtained when iterating over a directory) in Littlefs is not exactly what is expected. This implementation contains 2 comparision functions, one matching what is expected, and one matching the iteration order of littlefs directories, as described in littlefs-project/littlefs#923 The fact that directories are ordered is documented: https://github.com/littlefs-project/littlefs/blob/f53a0cc961a8acac85f868b431d2f3e58e447ba3/SPEC.md?plain=1#L304
sosthene-nitrokey
force-pushed
the
path-ord
branch
from
e8d646f
to
99b1a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path: Add ordering comparison functions
The ordering of path (as obtained when iterating over a directory) in Littlefs
is not exactly what is expected.
This implementation contains 2 comparision functions, one matching what is expected,
and one matching the iteration order of littlefs directories,
as described in littlefs-project/littlefs#923
The fact that directories are ordered is documented:
https://github.com/littlefs-project/littlefs/blob/f53a0cc961a8acac85f868b431d2f3e58e447ba3/SPEC.md?plain=1#L304