Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the react render, to use reactDOM.render #263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sbrady
Copy link

@sbrady sbrady commented Jun 3, 2016

No description provided.

@jdcantrell
Copy link
Contributor

Nice! Do you think it'd be helpful to also change <script type=\"text/jsx\" to <script type=\"text/babel\">? I started to make this change a week ago and then got distracted.

@sbrady
Copy link
Author

sbrady commented Jun 12, 2016

yes I think so, I'll do that.

I am not sure why the Travis build failed

@sbrady
Copy link
Author

sbrady commented Jun 13, 2016

Seems like this might be a little tricky, see: babel/babel-standalone#15

Although version 5 still supports in browser transformations.
<script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.23/browser.min.js"></script>
should we document this somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants