NAS-133053 / 25.04 / Disable API keys if used over insecure transport #15457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
reviewed
Jan 22, 2025
anodos325
requested review from
yocalebo,
bmeagherix,
mgrimesix and
billohanlon
bmeagherix
reviewed
Jan 22, 2025
bmeagherix
approved these changes
Jan 22, 2025
mgrimesix
approved these changes
Jan 22, 2025
yocalebo
reviewed
Jan 22, 2025
yocalebo
reviewed
Jan 22, 2025
This commit adds a new property (secure_transport) to ConnectionOrigin to indicate whether the websocket session has secure transport. This flag is set in the following scenarios: 1) AF_UNIX 2) localhost 3) https / wss 4) ha connection New behavior based on security team feedback is introduced in this commit such that API keys will be automatically revoked when used over insecure transport. This is to prevent them being used in replay attacks.
yocalebo
approved these changes
Jan 22, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new attribute (secure_transport) to ConnectionOrigin to indicate whether the websocket session has secure transport. This flag is set in the following scenarios:
New behavior based on security team feedback is introduced in this commit such that API keys will be automatically revoked when used over insecure transport. This is to prevent them being used in replay attacks.