Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133703 / 25.04 / Raise ValidationError on perm change for readonly paths #15452

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

anodos325
Copy link
Contributor

This commit introduces additional validation to check whether the path on which user is trying to change permissions is set to readonly. This appears to be a fairly common occurance with our SCALE userbase and so we need to cleanly explain why they can't do this.

This commit introduces additional validation to check whether the
path on which user is trying to change permissions is set to
readonly. This appears to be a fairly common occurance with our
SCALE userbase and so we need to cleanly explain why they can't
do this.
@anodos325 anodos325 added the jira label Jan 21, 2025
@anodos325 anodos325 requested a review from a team January 21, 2025 17:16
@bugclerk bugclerk changed the title Raise ValidationError on perm change for readonly paths NAS-133703 / 25.04 / Raise ValidationError on perm change for readonly paths Jan 21, 2025
@bugclerk
Copy link
Contributor

Copy link
Contributor

@bmeagherix bmeagherix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have been nice to have a test, but otherwise LGTM.

@anodos325 anodos325 merged commit 4f404a5 into master Jan 21, 2025
2 checks passed
@anodos325 anodos325 deleted the add-validation-readonly branch January 21, 2025 17:55
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants