NAS-132908 / 25.04 / optimize pool.dataset.details #15436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
anodos325
approved these changes
Jan 20, 2025
yocalebo
force-pushed
the
NAS-132908
branch
3 times, most recently
from
d739e8e to
b2a04a5
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly pass in valid pools to
pool.dataset.queryso we're not querying boot pool information. Even thoughpool.dataset.querydoesn't return boot pool information, it still asks zfs for that information by default. To skip the boot pool, we need to explicitly query the zpools we're interested in. This can, potentially, save a tremendous amount of time on systems that have a large amount of boot environments.