NAS-130995 / 25.04 / Allow retrieving logs of apps in crashed state #14419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
reviewed
Sep 4, 2024
Qubad786
force-pushed
the
mrehan/crashed-state-apps
branch
from
469e617 to
2c9e216
Compare
yocalebo
reviewed
Sep 4, 2024
Qubad786
force-pushed
the
mrehan/crashed-state-apps
branch
from
2c9e216 to
f996830
Compare
yocalebo
reviewed
Sep 4, 2024
Qubad786
force-pushed
the
mrehan/crashed-state-apps
branch
from
f996830 to
4f2b59a
Compare
yocalebo
approved these changes
Sep 4, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently only those app's logs can be viewed which have containers which are either all running or at least one of them is in running or starting state. However this leads to the problem when an app has containers where all of them have crashed for any reason i.e bad configuration / app issues, unfortunately it is not possible to view logs for those apps yet.
A
CRASHEDstate has been introduced which covers the case mentioned above where all the containers in the app if have crashed, that app is marked asCRASHEDand we would still be able to view logs of such apps.