Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130905 / 25.04 / Remove REST from test_050_alert.py #14415

Merged
merged 16 commits into from
Sep 11, 2024
Merged

NAS-130905 / 25.04 / Remove REST from test_050_alert.py #14415

merged 16 commits into from
Sep 11, 2024

Conversation

creatorcary
Copy link
Contributor

@creatorcary creatorcary commented Sep 4, 2024 •
edited
Loading

@creatorcary creatorcary requested a review from a team September 4, 2024 16:29
@bugclerk bugclerk changed the title Remove REST from test_050_alert.py NAS-130905 / 25.04 / Remove REST from test_050_alert.py Sep 4, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Sep 4, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130905

yocalebo
yocalebo requested changes Sep 4, 2024
View reviewed changes
tests/api2/test_alert.py Outdated Show resolved Hide resolved
tests/api2/test_alert.py Outdated Show resolved Hide resolved
tests/api2/test_alert.py Outdated Show resolved Hide resolved
tests/api2/test_alert.py Outdated Show resolved Hide resolved
@yocalebo yocalebo requested a review from a team September 4, 2024 16:41
@creatorcary creatorcary force-pushed the NAS-130905 branch 2 times, most recently from 504ac73 to 7743480 Compare September 4, 2024 19:03
@creatorcary creatorcary requested a review from yocalebo September 4, 2024 19:04
themylogin
themylogin requested changes Sep 5, 2024
View reviewed changes
tests/api2/test_alert.py Outdated Show resolved Hide resolved
tests/api2/test_alert.py Outdated Show resolved Hide resolved
@creatorcary creatorcary added the WIP label Sep 6, 2024
@creatorcary creatorcary force-pushed the NAS-130905 branch 2 times, most recently from 63b71cf to 898e4ca Compare September 9, 2024 13:30
@creatorcary creatorcary removed the WIP label Sep 9, 2024
themylogin
themylogin approved these changes Sep 9, 2024
View reviewed changes
tests/api2/test_alert.py Show resolved Hide resolved
@creatorcary
Copy link
Contributor Author

One failed test, don't think it's related though: http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/621/

themylogin
themylogin approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@themylogin themylogin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@creatorcary creatorcary merged commit b907a48 into master Sep 11, 2024
3 checks passed
@creatorcary creatorcary deleted the NAS-130905 branch September 11, 2024 16:33
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

@themylogin themylogin themylogin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@creatorcary @bugclerk @themylogin @yocalebo