Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130418 / 24.10 / Audit filesystem permissions changes #14124

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

anodos325
Copy link
Contributor

This adds basic auditing for API calls that change filesystem permissions.

@bugclerk
Copy link
Contributor

bugclerk commented Aug 5, 2024

@bugclerk bugclerk changed the title Audit filesystem permissions changes NAS-130418 / 24.10 / Audit filesystem permissions changes Aug 5, 2024
This adds basic auditing for API calls that change filesystem
permissions.
@anodos325 anodos325 force-pushed the add-audit-permissions branch from a825479 to 31b1769 Compare August 5, 2024 13:10
@anodos325 anodos325 removed the WIP label Aug 5, 2024
@anodos325 anodos325 requested review from a team, mgrimesix and bmeagherix August 5, 2024 13:10
Copy link
Contributor

@bmeagherix bmeagherix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests for a couple of the APIs (set_zfs_attributes, add_to_acl), but considering how similar the changes are the the other tested APIs, I'll approve,.

@anodos325 anodos325 merged commit 0dc6787 into master Aug 5, 2024
2 of 3 checks passed
@anodos325 anodos325 deleted the add-audit-permissions branch August 5, 2024 13:35
@bugclerk
Copy link
Contributor

bugclerk commented Aug 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants