NAS-128003 / 24.10 / Update zvol collection method #14076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a depth search. Fixed a few typos in TRUENAS-MIB.txt which includes regenerating TRUENAS-MIB.py. Added a context manager for simple 'file' creations in the filesystem asset. Created a CI test in test_440_snmp.py for this issue.
bugclerk
changed the title
yocalebo
reviewed
Jul 25, 2024
yocalebo
reviewed
Jul 25, 2024
src/middlewared/middlewared/test/integration/assets/filesystem.py
Outdated
Show resolved
Hide resolved
Changed name of context manager from file to mkfile Added a couple comments
yocalebo
approved these changes
Jul 25, 2024
bmeagherix
reviewed
Jul 25, 2024
src/middlewared/middlewared/test/integration/assets/filesystem.py
Outdated
Show resolved
Hide resolved
That exposed an issue with processing the SNMP output. Fixed processing of the SNMP output. Fixed other items raised in the review.
bmeagherix
approved these changes
Jul 26, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The TrueNAS snmp agent was reporting zvols that resided directly on a pool. However, zvols can be created in any dataset which means we don't report all possible zvols.
Fix
Change the method to find zvols by doing a full depth search on each pool found in
/dev/zvolCreated a CI test for this condition.
Included in this PR: