Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130199 / 24.10 / Make sure docker networks get recreated with compose up action #14070

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Qubad786
Copy link
Contributor

Problem

When we have a running app and system is rebooted, any docker networks which might have been created don't have their associated interfaces anymore present after the reboot. So if an attempt to start the app is made, what happens is that process fails. For starting the app docker compose up --force-recreate is used, however this does not re-create the docker networks and eventually the interfaces as well which are associated with it. It fails with something like

Error response from daemon: failed to create endpoint ix-nginx-perms-1 on network ix-nginx_default: adding interface vethb6475a1 to bridge br-62cbfa232e0b failed: Device does not exist

Solution

We make sure whenever compose up action is desired, any networks in place are removed first for the app so that the app can safely start.

@Qubad786 Qubad786 added the jira label Jul 24, 2024
@Qubad786 Qubad786 requested a review from a team July 24, 2024 00:32
@bugclerk bugclerk changed the title Make sure docker networks get recreated with compose up action NAS-130199 / 24.10 / Make sure docker networks get recreated with compose up action Jul 24, 2024
@bugclerk
Copy link
Contributor

1 similar comment
@bugclerk
Copy link
Contributor

@Qubad786 Qubad786 merged commit ff6e85e into master Jul 24, 2024
2 of 3 checks passed
@Qubad786 Qubad786 deleted the mrehan/fix-compose-action branch July 24, 2024 00:38
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants