NAS-130095 / 24.10 / Fix typos in directory services plugin #14035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two bugs that were introduced on fresh boot of TrueNAS and weren't caught in testing due to particulars of how reinstalling middleware happens in our CI. The method to create a persistent keyring was refactored away during development and a typo was present in code path only exercised on first boot.
bugclerk
changed the title
Qubad786
approved these changes
Jul 18, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs that were introduced on fresh boot of TrueNAS and weren't caught in testing due to particulars of how reinstalling middleware happens in our CI. The method to create a persistent keyring was refactored away during development and a typo was present in code path only exercised on first boot.