NAS-130069 / 24.10 / Fix API key API #14030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
time 1:30 |
anodos325
approved these changes
Jul 17, 2024
creatorcary
reviewed
Jul 17, 2024
| class ApiKeyEntryWithKey(ApiKeyEntry): | ||
| key: Private[str] | ||
|
|
||
|
|
||
| class ApiKeyCreate(ApiKeyEntry): | ||
| id: Excluded = excluded_field() | ||
| key: Excluded = excluded_field() |
There was a problem hiding this comment.
Since ApiKeyEntry no longer has a key, it seems like this line can be removed.
tests/api2/test_api_key_crud.py
Outdated
|
|
||
|
|
||
| def test_has_key_after_creation_but_not_read(): | ||
| api_key = call("api_key.create", {"name": "Test", "allowlist": []}) |
There was a problem hiding this comment.
It's a little confusing to use the name of a function as the name of a local variable imo
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.