Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129046 / 24.10 / Fix several test regressions due to removing ip #13747

Merged
merged 1 commit into from
May 16, 2024

Conversation

anodos325
Copy link
Contributor

In an earlier commit ip was removed from auto_conf generated by runtest.py. This exposed several remaining usages of it in our tests when running as a non-HA that were not caught in earlier testing.

In an earlier commit `ip` was removed from auto_conf generated by
runtest.py. This exposed several remaining usages of it in our tests
when running as a non-HA that were not caught in earlier testing.
@anodos325 anodos325 requested a review from yocalebo May 16, 2024 18:42
@anodos325 anodos325 added the jira label May 16, 2024
@bugclerk bugclerk changed the title Fix several test regressions due to removing ip NAS-129046 / 24.10 / Fix several test regressions due to removing ip May 16, 2024
@bugclerk
Copy link
Contributor

@anodos325 anodos325 merged commit c11663d into master May 16, 2024
2 of 3 checks passed
@anodos325 anodos325 deleted the fix-more-test branch May 16, 2024 18:45
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants