streamline connection to WRDS in "connect_WRDS.R" #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new script connect_WRDS.R contains both (i) the request for WRDS credentials and (ii) the actual establishment of the connection to WRDS.
to (i): section on WRDS credentials will
rstudioapi::askForPassword
for pop-ups to enter wrds credentials, if RStudio is not runningto (ii): extracted & excluded from "pull_wrds_data.R" to keep the script's focus on the download of data (what is pulled, not how). wrds_user and wrds_pwd should be removed, once connection is established.
connect_WRDS.R makes read_config.R obsolet
I also renamed the save_wrds_data function to save_rds_versionctrl because its only applicable to rds-files.
sorry for the many requested changes in 1 pull request. will adapt README once we agree on a final solution.