Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline connection to WRDS in "connect_WRDS.R" #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arndtupb
Copy link
Member

@arndtupb arndtupb commented Dec 9, 2021

new script connect_WRDS.R contains both (i) the request for WRDS credentials and (ii) the actual establishment of the connection to WRDS.

to (i): section on WRDS credentials will

  • check for existence of config.csv, if missing will
  • check for RStudio environment (e.g. when script is individually executed in RStudio to pull data) and uses rstudioapi::askForPassword for pop-ups to enter wrds credentials, if RStudio is not running
  • stop with customized error message

to (ii): extracted & excluded from "pull_wrds_data.R" to keep the script's focus on the download of data (what is pulled, not how). wrds_user and wrds_pwd should be removed, once connection is established.

connect_WRDS.R makes read_config.R obsolet

I also renamed the save_wrds_data function to save_rds_versionctrl because its only applicable to rds-files.

sorry for the many requested changes in 1 pull request. will adapt README once we agree on a final solution.

@arndtupb
Copy link
Member Author

arndtupb commented Dec 9, 2021

sorry for mixing things in two commits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant