Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing problem with .pdb files in Debug version #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThibaultDECO
Copy link

  • replacing the default /Zi in MSVC with /Z7, so that the debugging information ends up embedded in the .lib file rather than separate .pdb files.
  • forcing cmake to override the default cache

- replacing the default /Zi in MSVC with /Z7, so that the debugging information ends up embedded in the .lib file rather than separate .pdb files.
- forcing cmake to override the default cache
@aral-matrix
Copy link
Collaborator

Hi @ThibaultDECO - while my understanding of cmake is limited, do you still remember why you thought it was a good idea to have debug symbols included in the library binary? If MSVC offers to have debug information in separate files, why not make use of that?

@ThibaultDECO
Copy link
Author

Hi @aral-matrix
Unfortunately, I don't remember, it was too long time ago

@aral-matrix
Copy link
Collaborator

Thanks for getting back to me / responding here anyways. Would you be okay to close (or for me to close) the pull request then?

I believe that your pull request implements something that was very specific to your use case, and even you yourself only needed it for debugging - so without really understanding the consequences or being able to properly test it, I would prefer to not accept this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants