Replace GCC __ATOMIC* built-ins with std::atomic for interpreter.cc
#4976
+76
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
|
I think For example, |
|
We have discussed it a while ago but was not able to find a stable solution. I think the bottom line is probably that we cannot directly replace it with |
peterbell10
reviewed
Oct 23, 2024
| @@ -95,13 +88,15 @@ template <typename DType> class AtomicRMWOpBase : public AtomicOp { | |||
| protected: | |||
| void applyAt(void *loc, size_t i) override final { | |||
| if (mask[i]) { | |||
| std::atomic<DType> *atomic_ptr = static_cast<std::atomic<DType> *>(loc); | |||
There was a problem hiding this comment.
While this usually works in practice, it's also undefined behavior which isn't great. C++20 has std::atomic_ref which would fix this issue but we don't compile with C++20 yet.
|
@Jokeren @peterbell10 thanks for the review! I will try to address the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#include <atomic>is already used in other triton files, so I believe it's not a cardinally change.Changes come from #4045