Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] [BC breaking] Always follow C semantics on % #4955

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Frontend] [BC breaking] Always follow C semantics on % #4955

wants to merge 4 commits into from

Commits on Oct 19, 2024

  1. [Frontend] [BC breaking] Always follow C semantics on % 

    The semantics of `%` in triton used to be type dependant (!!).

With this PR, we make `%` always follow C semantics, similar to `//`.

We update the type promotion docs fixing some inaccuracies. It is still
not entirely precise though. For a discussion of the current semantics
see triton-lang#4697
    @lezcano @brod4910
    lezcano authored and brod4910 committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    7f0fabf View commit details
    Browse the repository at this point in the history

  2. fix interpreter to use np.fmod for C % semantics

    @brod4910
    brod4910 committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    cdaeed9 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. bump binary op test tolerance

    @brod4910
    brod4910 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f3c72c5 View commit details
    Browse the repository at this point in the history

  2. add (uint16, float32) ill conditioned mod op

    @brod4910
    brod4910 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    29b2ada View commit details
    Browse the repository at this point in the history