Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for iOS 11. #68

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Conversation

iosdevzone
Copy link
Contributor

The structure of UINavigationBar has changed in iOS 11. This meant that navigation bar was not fading out and was clashing with the status bar. I modified the code to recursively apply the new alpha value. The change should be benign on older OS versions.

This PR may solve issue #67.

@aldrincb
Copy link

aldrincb commented Nov 7, 2017

If you push a view controller to the hiding navigation controller, the nav bar buttons are delayed in dismissing when popped.

@tristanhimmelman tristanhimmelman merged commit 1e66256 into tristanhimmelman:master Mar 12, 2018
@tristanhimmelman
Copy link
Owner

Thanks for this fix and sorry it took so long to merge, I completely missed this PR.

@scelis
Copy link

scelis commented Aug 27, 2018

@tristanhimmelman This change appears to have broken pop animations in our UINavigationBar -- specifically the way the back button animates after you tap it.

This is using Xcode 9.4.1 and iOS 11.

navigationbar

@robrichardson13
Copy link

robrichardson13 commented Sep 5, 2018

This change also caused issues when the NavigationBar has a UISearchBar inside of it. It causes the search bars Cancel button to appear when the bar expands. For our case, just made it skip changing the alpha for that specific button.

@tristanhimmelman
Copy link
Owner

Hey guys, sorry to hear that. If one of you would be willing to create a PR to revert the change I would be happy to review and merge it. Unfortunately I just dont have the time to make updates myself at the moment. Thanks

@scelis
Copy link

scelis commented Sep 11, 2018

@tristanhimmelman I would be happy to open up a PR to revert this change, but I was unclear what the original change was hoping to accomplish and what reverting this PR might affect. However, if you'd like that PR just let me know. Or, you can always easily revert a PR on GitHub using the Revert button above next to the line item:

tristanhimmelman merged commit 1e66256 into tristanhimmelman:master on Mar 11

@iosdevzone
Copy link
Contributor Author

Hi all,

Sorry this change is causing issues. It was initially introduced to solve a problem with iOS 11 where you were left with your back button still visible and overlaying the status bar. This still occurs in iOS 12 for the iPhone X (perhaps it only occurred on this model for iOS 11?, I don't have an emulator or device handy at the moment).

Here's what you'll get if you simply revert and run the sample project. (Run on device, iOS 12, iPhone X).

img_2427

Apologies for the delay in responding to this thread, I've been away from iOS development for a while as my day job has been hectic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants