Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on := sorry not := by sorry #239

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Standardize on := sorry not := by sorry #239

merged 1 commit into from
Oct 23, 2024

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Oct 23, 2024 •
edited
Loading

@GeorgeTsoukalas in #238 (comment) said:

Could you remove by here? The convention for the rest of the Lean formalizations is not to enter tactic mode by default.

@eric-wieser eric-wieser mentioned this pull request Oct 23, 2024
Merged
GeorgeTsoukalas
GeorgeTsoukalas approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@GeorgeTsoukalas GeorgeTsoukalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Looks like I missed these earlier. Thanks for the contribution Eric!

@GeorgeTsoukalas GeorgeTsoukalas merged commit 64211ad into trishullab:main Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeTsoukalas GeorgeTsoukalas GeorgeTsoukalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-wieser @GeorgeTsoukalas