Fix flaky testUpdateWithSortOrder #24890
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make testUpdateWithSortOrder run in isolation to avoid flaky failures.
ebyhr
reviewed
Feb 4, 2025
| @@ -1565,6 +1569,7 @@ public void testOptimizeWithSortOrder() | |||
| } | |||
|
|
|||
| @Test | |||
| @ResourceLock(value = "BaseIcebergConnectorTest", mode = READ_WRITE) | |||
There was a problem hiding this comment.
@lukasz-stec Did you try the existing AbstractTestQueryFramework#executeExclusively method?
@martint This is the 1st usage of @ResourceLock annotation. Can we use it for isolating tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make testUpdateWithSortOrder run in isolation
to avoid flaky failures.
Description
Additional context and related issues
Fixes #24866
Release notes
( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: