[WIP] Parse invalid numbers and throw an error #24799
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a rule to parse numbers with invalid placement of underscores, either trailing, consecutive,
or beside the decimal point. Throw an error if such a number is found.
Note: numbers with a leading underscore are also invalid, but depending on the context
they are valid identifiers, e.g.,
LIMIT _123
is invalid, butSELECT _123
is not. Detecting thesecases would require deeper changes to the grammar, which may not be warranted just to
produce a better error message.
Additional context and related issues
#24784
Release notes
(x) Release notes are required, with the following suggested text: