Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not merge] Testing vale capitalization #246

Closed
wants to merge 12 commits into from
Closed

[do not merge] Testing vale capitalization #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b45d449
Test stuff for vale
timothymcmackin Jan 4, 2024
b14de92
try parens in the vale rule
timothymcmackin Jan 4, 2024
c5637f3
adding another line about smart rollups
timothymcmackin Jan 4, 2024
ddb0798
trigger vale
timothymcmackin Jan 4, 2024
90d23bd
try with capture group
timothymcmackin Jan 4, 2024
cabf449
try with a bar
timothymcmackin Jan 4, 2024
04b1dd9
capture groups
timothymcmackin Jan 4, 2024
2842cb7
ignorecase: false
timothymcmackin Jan 4, 2024
8b48282
more text
timothymcmackin Jan 4, 2024
b8ddd12
parens and bars
timothymcmackin Jan 4, 2024
93e7ff9
format groups correctly
timothymcmackin Jan 4, 2024
1be7544
try this
timothymcmackin Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions docs/valeTest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
title: Testing Vale
---

Here are some things that Vale should pick up:

This is the official Tezos implementation of Vale.

It is in a chapter and an article.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Terms] Do not use the term 'chapter'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Terms] Do not use the term 'article'


We have l1 and l2, which is smart rollups.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Tezos.Substitutions] Use 'layer 1' instead of 'l1'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Tezos.Substitutions] Use 'layer 2' instead of 'l2'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Capitalize] Always capitalize 'Smart Rollups'


We love smart rollups.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Capitalize] Always capitalize 'Smart Rollups'


The term Smart Contracts should not be capitalized.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.DoNotCapitalize] Do not capitalize 'smart contract'


What if I failed to capitalize smart rollups on a different line?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Capitalize] Always capitalize 'Smart Rollups'


Adding another line about smart rollups.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Capitalize] Always capitalize 'Smart Rollups'


Some other things about smart rollups.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Capitalize] Always capitalize 'Smart Rollups'

5 changes: 3 additions & 2 deletions test/styles/Tezos/Capitalize.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
extends: substitution
message: "Always capitalize '%s'"
level: error
ignorecase: true
swap:
'[Ss]mart rollup': "Smart Rollup"
'smart [Rr]ollup': "Smart Rollup"
smart rollup: Smart Rollup
smart rollups: Smart Rollups