Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not merge] Testing Vale rules #241

Closed
wants to merge 6 commits into from
Closed

[do not merge] Testing Vale rules #241

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ccd5ffb
Test file with some problems
timothymcmackin Jan 3, 2024
59d6383
try without vale-flags
timothymcmackin Jan 3, 2024
f3e68c8
github-pr-review
timothymcmackin Jan 3, 2024
5c55ec5
try explicitly setting files
timothymcmackin Jan 3, 2024
9ae2438
Revert "try explicitly setting files"
timothymcmackin Jan 3, 2024
f433cde
Revert "github-pr-review"
timothymcmackin Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/vale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ jobs:
- uses: errata-ai/vale-action@reviewdog
with:
files: docs
reporter: github-pr-check
reporter: github-pr-review
filter_mode: added
vale_flags: "--glob=*.{md,mdx}"
# vale_flags: "--glob=*.{md,mdx}"
11 changes: 11 additions & 0 deletions docs/valeTest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
title: Testing Vale
---

Here are some things that Vale should pick up:

This is the official Tezos implementation of Vale.

It is in a chapter and an article.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Legal] Do not use the term 'chapter'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Tezos.Legal] Do not use the term 'article'


We have l1 and l2, which is smart rollups.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Tezos.Substitutions] Use 'layer 1' instead of 'l1'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Tezos.Substitutions] Use 'layer 2' instead of 'l2'