forked from LedgerHQ/app-tezos-legacy
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade baking app and remove wallet app code #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests: test properly the `HMAC`
The default value used in Makefile.standard_app
Upgrade Makefile to be compatible with LedgerHQ/app-boilerplate
- remove athens operations - keep only babylon reveal and delegation operations as they are identical to the delegation and the reveal of Oxford and they are the only operations still used.
…egacy-code Remove parser legacy code
As ledger provides docker containers for build environment, nix setup is no longer required.
…er-reported-issues Fix minor ledger reported issues
…n and attestation
…sion v3.10 datetime package
…etween-pre-attestation-and-attestation-based-on-magic-byte Use magic byte instead of tag to differentiate between pre-attestation and attestation
The MetaScreen metaclass prevent TezosUseCaseAddressConfirmation to inherit properly UseCaseAddressConfirmation
- screen contains more data: number of screen reduced - swipe instead of tap - QR button has moved
fixed in Ragger v1.21.0
…p-builder-version Bump ledger-app-builder version
black_screen snapshots remains from older version
In order to clarify the tests
- nbgl_useCaseAddressReview instead of nbgl_useCaseAddressConfirmation - nbgl_useCaseReviewStatus instead of nbgl_useCaseStatus
- nbgl_useCaseReviewStart instead of nbgl_useCaseReviewLight and nbgl_useCaseStaticReviewLight - standard status message
- nbgl_useCaseGenericReview instead of nbgl_useCaseReviewStart The pre-defined review flows do not meet our expectations as they are built specifically for reviewing/signing transactions/messages and therefore the wording is defined for this. - standard status message
- nbgl_useCaseGenericReview instead of nbgl_useCaseReviewStart The pre-defined review flows do not meet our expectations as they are built specifically for reviewing/signing transactions/messages and therefore the wording is defined for this. - standard status message
- check_app_context: only check data and not the screens - goto_home_public_key: do not check chain_id - disable_hwm: do not check app_context
In order to move all parameter information to the end of the flow as required for useCaseHomeAndSettings
Instead of useCaseHome and nbgl_useCaseSettings
…seCases Use standard use cases
NOt relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Remove wallet app code
-- Update tezos protocol in baking app as per oxford/paris upgrade of tezos
-- Add ragger tests
-- remove manual io_event handling and screensavers. use ledger screensaver
-- Refactor error handling from exception to return error codes