Optimize bls #122
Optimize bls #122
Conversation
Unused if the command is SIGN and the curve of the signee key is BLS
spalmer25
force-pushed
the
palmer@functori@optimize-bls
branch
from
a18206b
to
9214c95
Compare
prepare to stop derivating the pk too frequently
Since `global.public_key` is the key associated to `global.path_with_curve`, if the `path_with_curve` to derive is equal to `global.path_with_curve`, then the key associated to the `path_with_curve` is `global.public_key`. There is no need to re-derive it again.
spalmer25
force-pushed
the
palmer@functori@optimize-bls
branch
from
9214c95
to
1c55f5a
Compare
| #ifndef TARGET_NANOS | ||
| // There is no need to hash the message if it is not used for signing or if it is not sent at | ||
| // the end. | ||
| if (with_hash || (global.path_with_curve.derivation_type != DERIVATION_TYPE_BLS12_381)) { |
There was a problem hiding this comment.
What is the purpose of with_hash here. Is it used for BLS.
There was a problem hiding this comment.
I mean if the derivation type is BLS dont hash at all.
There was a problem hiding this comment.
The with_hash comes from the request SIGN_WITH_HASH.
We have to compute/send it if the sender requests it.
| @@ -33,6 +33,26 @@ | |||
| #include <stdint.h> | |||
| #include <string.h> | |||
|
|
|||
| tz_exc read_path_with_curve(derivation_type_t derivation_type, | |||
There was a problem hiding this comment.
The derivation type is selected at the time of setup. It can not be changed during signing. so it makes sense to derivce the public key when read_path_with_curve is called from handle_setup. Rather create a new function setup_path_with_curve and derive public key there along with a call to read_path_with_curve. Call setup_path_with_curve from handle_setup and read_path_with_curve from other places.
There was a problem hiding this comment.
The SETUP instruction is not required to sign:
AUTHORIZE_BAKINGwill setup the authorized key too.- If the authorized key was present in the RAM,
SIGNwith index 0x00 will tell which public key to sign with
The aims of this function is too make sure that, every time the stored Bip32-path-with-curve is updated, the stored PK is updated to.
| TZ_ASSERT(read_bip32_path(buf, &tmp_path_with_curve.bip32_path), EXC_WRONG_VALUES); | ||
|
|
||
| // Do not derive the public key if the two path_with_curve are equal | ||
| if (!bip32_path_with_curve_eq(path_with_curve, &tmp_path_with_curve)) { |
There was a problem hiding this comment.
It seems my previous comment is addressed here. you can still think if a setup_path_with_curve makes sense.
This PR add optimization to BLS signing.