-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows to sign using the BLS curve #121
Conversation
c990563
to
09147e0
Compare
test/snapshots/nanos/test_sign_delegation/BLS_tz4Gk6EphzZnu84iEGMV24qwU38vrXSxtw7L/00007.png
Outdated
Show resolved
Hide resolved
c5c8a1c
to
4591406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if eth apps do this or any other app does this? As a last resort we can just ask ledger if saving the private key to RAM is safe or should be avoided .
too avoid manual convertion
- use `cx_ecfp_256_public_key_t` instead of `cx_ecfp_public_key_t` because it will become an abstract type - create an union in order to be able to handle all `cx_ecfp_public_key_t` at the same time. `cx_ecfp_384_public_key_t` will be add later for BLS keys
- alias `cx_ecfp_compressed_public_key_t` to differentiate it from `cx_ecfp_public_key_t` - use customize `cx_ecfp_public_key_t` to fit tezos compressed public key and merge them in a struct `tz_ecfp_compressed_public_key_t`
- use directly derivation_type - inline derivation_mode
- gen pk - sign - parsable in operations
As the BLS signature uses its own hash function
- init hash state at first packet - let cx_hash_no_throw handle the hashing
4591406
to
c4ef534
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Associated
LedgerHQ/ledger-app-database
PR: LedgerHQ/ledger-app-database#279