Use standard use cases #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmer25
force-pushed
the
palmer@functori@use-standard-useCases
branch
2 times, most recently
from
7ef9244
to
3698c97
Compare
This was
linked to
issues
Jul 25, 2024
black_screen snapshots remains from older version
In order to clarify the tests
spalmer25
force-pushed
the
palmer@functori@use-standard-useCases
branch
from
3698c97
to
70cf539
Compare
spalmer25
force-pushed
the
palmer@functori@use-standard-useCases
branch
from
70cf539
to
1524f28
Compare
- nbgl_useCaseAddressReview instead of nbgl_useCaseAddressConfirmation - nbgl_useCaseReviewStatus instead of nbgl_useCaseStatus
- nbgl_useCaseReviewStart instead of nbgl_useCaseReviewLight and nbgl_useCaseStaticReviewLight - standard status message
- nbgl_useCaseGenericReview instead of nbgl_useCaseReviewStart The pre-defined review flows do not meet our expectations as they are built specifically for reviewing/signing transactions/messages and therefore the wording is defined for this. - standard status message
- nbgl_useCaseGenericReview instead of nbgl_useCaseReviewStart The pre-defined review flows do not meet our expectations as they are built specifically for reviewing/signing transactions/messages and therefore the wording is defined for this. - standard status message
- check_app_context: only check data and not the screens - goto_home_public_key: do not check chain_id - disable_hwm: do not check app_context
In order to move all parameter information to the end of the flow as required for useCaseHomeAndSettings
Instead of useCaseHome and nbgl_useCaseSettings
spalmer25
force-pushed
the
palmer@functori@use-standard-useCases
branch
from
33ebe57
to
c7c0f99
Compare
ajinkyaraj-23
approved these changes
Jul 26, 2024
spalmer25
force-pushed
the
palmer@functori@use-standard-useCases
branch
from
2629f24
to
9000f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.