Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE MueLu: Cut drop refactor #13282

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Commits on Jul 25, 2024

  1. MueLu: Cut Drop Converted to Use Kokkos

    Original code within ORIGINAL ifdef. New code within NEW ifdef.
    DropTol structure marked with KOKKOS_INLINE_FUNCTION and default values are hard coded.
    Default Algorithm and Cut Drop Algorithm split into separate for loops in NEW code.
    Cut Drop converted to use Kokkos nested parallel loops.
    Timers placed in new code and are commented out.
    Code passes current unit tests.
    Saw a speedup of about 1.5x with Cuda and 1.2x with Serial when running unit tests with 10,000,000 rows.
    
    Signed-off-by: Ian Halim <[email protected]>
    Ian Halim committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e67173a View commit details
    Browse the repository at this point in the history
  2. MueLu: Cut Drop Memory Optimization

    DropTol structure in algorithm replaced with new, smaller DropTolKokkos structure.
    Computations are now done on the fly.
    Code passes current unit tests.
    No significant change in speed.
    
    Signed-off-by: Ian Halim <[email protected]>
    Ian Halim committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    105e33e View commit details
    Browse the repository at this point in the history
  3. MueLu: Sorting Now Resembles numpy.argsort

    Per Christian's request.
    DropTolKokkos structure removed and replaced with view indices and view of drop flags.
    ORIGINAL code removed.
    BuildKokkos removed.
    Removed commented out timers.
    Added comments.
    
    Signed-off-by: Ian Halim <[email protected]>
    Ian Halim committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    cdee728 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. MueLu: std::complex Replaced With Kokkos::complex

    Signed-off-by: Ian Halim <[email protected]>
    Ian Halim committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7c78025 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. MueLu: Code Review Fixes

    Signed-off-by: Ian Halim <[email protected]>
    Ian Halim committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4dff65a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. MueLu: Fixing Issue trilinos#13377 and trilinos#13378

    Issues listed above have been addressed.
    Threshold has been redefined to 1/threshold.
    Unit tests have been modified to be more thorough.
    
    Signed-off-by: Ian Halim <[email protected]>
    Ian Halim committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1317d90 View commit details
    Browse the repository at this point in the history