MueLu Hierarchy: Only warn during setup about lack of smoother/coarse…

… solver A warning in every single iteration is a bit much.
trilinos · Apr 4, 2024 · 5bb8be6 · 5bb8be6
1 parent c29ace0
commit 5bb8be6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/packages/muelu/src/Interface/MueLu_HierarchyManager.hpp b/packages/muelu/src/Interface/MueLu_HierarchyManager.hpp
@@ -283,6 +283,7 @@ class HierarchyManager : public HierarchyFactory<Scalar, LocalOrdinal, GlobalOrd
     // This is cached, but involves and MPI_Allreduce.
     H.description();
     H.describe(H.GetOStream(Runtime0), verbosity_);
+    H.CheckForEmptySmoothersAndCoarseSolve();
 
     // When we reuse hierarchy, it is necessary that we don't
     // change the number of levels. We also cannot make requests

diff --git a/packages/muelu/src/MueCentral/MueLu_Hierarchy_decl.hpp b/packages/muelu/src/MueCentral/MueLu_Hierarchy_decl.hpp
@@ -247,6 +247,8 @@ class Hierarchy : public BaseClass {
 
   void SetupRe();
 
+  void CheckForEmptySmoothersAndCoarseSolve();
+
   //! Clear impermanent data from previous setup
   void Clear(int startLevel = 0);
   void ExpertClear();

diff --git a/packages/muelu/src/MueCentral/MueLu_Hierarchy_def.hpp b/packages/muelu/src/MueCentral/MueLu_Hierarchy_def.hpp
@@ -601,6 +601,8 @@ void Hierarchy<Scalar, LocalOrdinal, GlobalOrdinal, Node>::SetupRe() {
   ResetDescription();
 
   describe(GetOStream(Statistics0), GetVerbLevel());
+
+  CheckForEmptySmoothersAndCoarseSolve();
 }
 
 template <class Scalar, class LocalOrdinal, class GlobalOrdinal, class Node>
@@ -673,6 +675,17 @@ void Hierarchy<Scalar, LocalOrdinal, GlobalOrdinal, Node>::Setup(const FactoryMa
   manager.Clean();
 
   describe(GetOStream(Statistics0), GetVerbLevel());
+
+  CheckForEmptySmoothersAndCoarseSolve();
+}
+
+template <class Scalar, class LocalOrdinal, class GlobalOrdinal, class Node>
+void Hierarchy<Scalar, LocalOrdinal, GlobalOrdinal, Node>::CheckForEmptySmoothersAndCoarseSolve() {
+  for (LO levelNo = 0; levelNo < as<LO>(Levels_.size()); ++levelNo) {
+    auto level = Levels_[levelNo];
+    if ((!level->IsAvailable("PreSmoother")) && (!level->IsAvailable("PostSmoother")))
+      GetOStream(Warnings1) << "No " << (levelNo == as<LO>(Levels_.size()) - 1 ? "coarse grid solver" : "smoother") << " on level " << level->GetLevelID() << std::endl;
+  }
 }
 
 template <class Scalar, class LocalOrdinal, class GlobalOrdinal, class Node>
@@ -834,7 +847,6 @@ ConvergenceStatus Hierarchy<Scalar, LocalOrdinal, GlobalOrdinal, Node>::Iterate(
     emptyFineSolve = false;
   }
   if (emptyFineSolve == true) {
-    GetOStream(Warnings1) << "No fine grid smoother" << std::endl;
     // Fine grid smoother is identity
     fineX->update(one, B, zero);
   }
@@ -854,7 +866,6 @@ ConvergenceStatus Hierarchy<Scalar, LocalOrdinal, GlobalOrdinal, Node>::Iterate(
       emptyCoarseSolve = false;
     }
     if (emptyCoarseSolve == true) {
-      GetOStream(Warnings1) << "No coarse grid solver" << std::endl;
       // Coarse operator is identity
       coarseX->update(one, *coarseRhs, zero);
     }
@@ -1003,7 +1014,6 @@ ConvergenceStatus Hierarchy<Scalar, LocalOrdinal, GlobalOrdinal, Node>::Iterate(
         zeroGuess  = false;
       }
       if (emptySolve == true) {
-        GetOStream(Warnings1) << "No coarse grid solver" << std::endl;
         // Coarse operator is identity
         X.update(one, B, zero);
       }