-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON schema for flink-job #111
Conversation
8f758d4
to
9dbf855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to be able to remove many/all of the fail
and required
fields in https://github.com/trifork/cheetah-charts/blob/main/charts/flink-job/templates/_helpers.tpl.
Such as
{{- $name := required "topics.name is required" .name -}} |
topics[*].name
is required, and {{- fail (printf "Topic type %s not understood. Allowed values are: input, output" .type) -}} |
topics[*].type
must be input
or output
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
Co-authored-by: Anders Bennedsgaard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, but otherwise LGTM 😄
Co-authored-by: Anders Bennedsgaard <[email protected]>
Add JSON schema for flink-job
Continuation of #95
Implementing https://jira.trifork.com/browse/KAMDP-341
Used the following script to verify existing charts: