Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pty error #807

Merged
merged 1 commit into from
Jan 11, 2024
Merged

improve pty error #807

merged 1 commit into from
Jan 11, 2024

Conversation

squell
Copy link
Member

@squell squell commented Nov 28, 2023

This make it clear that the error that occurs when a PTY cannot be opened pertains to the PTY, and not to the command itself, i.e. it will produce:

sudo-rs: cannot execute '/usr/bin/ls': unable to open pty

@squell squell linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (328be1e) 57.46% compared to head (e544180) 57.36%.
Report is 11 commits behind head on main.

Files Patch % Lines
src/exec/use_pty/parent.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   57.46%   57.36%   -0.11%     
==========================================
  Files          74       74              
  Lines       10523    10559      +36     
==========================================
+ Hits         6047     6057      +10     
- Misses       4476     4502      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squell
Copy link
Member Author

squell commented Dec 8, 2023

Note: needs some work to figure out why the compliance test is failing.

Edit Passes the compliance tests locally. 🤔

Edit Seems just a GitHub issue. Very strange.

@squell squell added the help wanted Extra attention is needed label Dec 8, 2023
@squell squell force-pushed the improve-pty-error branch from 9eabbf6 to e544180 Compare January 10, 2024 10:35
@squell squell enabled auto-merge January 10, 2024 11:18
@squell squell removed the help wanted Extra attention is needed label Jan 10, 2024
@squell squell added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit 079569c Jan 11, 2024
15 checks passed
@squell squell deleted the improve-pty-error branch August 9, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sudo-rs in a clean chroot isn't behaving properly
2 participants