Skip to content

Commit

Permalink
Merge pull request YaoApp#238 from trheyi/main
Browse files Browse the repository at this point in the history
Add unzip step for libv8 in CI workflows
  • Loading branch information
trheyi authored Dec 10, 2024
2 parents 6396abb + 0f467e2 commit 7bba5ea
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 5 deletions.
14 changes: 12 additions & 2 deletions .github/workflows/pr-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,16 @@ jobs:
lfs: true
path: v8go

- name: Unzip libv8
run: |
files=$(find ./v8go -name "libv8*.zip")
for file in $files; do
dir=$(dirname "$file") # Get the directory where the ZIP file is located
echo "Extracting $file to directory $dir"
unzip -o -d $dir $file
rm -rf $dir/__MACOSX
done
- name: Checkout Demo WMS
uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -225,8 +235,8 @@ jobs:
- name: Codecov Report
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
# with:
# token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos

- name: "Comment on PR"
uses: actions/github-script@v6
Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,16 @@ jobs:
lfs: true
path: v8go

- name: Unzip libv8
run: |
files=$(find ./v8go -name "libv8*.zip")
for file in $files; do
dir=$(dirname "$file") # Get the directory where the ZIP file is located
echo "Extracting $file to directory $dir"
unzip -o -d $dir $file
rm -rf $dir/__MACOSX
done
- name: Checkout Demo WMS
uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -171,5 +181,5 @@ jobs:
- name: Codecov Report
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
# with:
# token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
3 changes: 2 additions & 1 deletion schedule/process.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,11 @@ func (sch *Schedule) handler() (func(), error) {
log.Error("[Schedule] %s %s %s", sch.name, sch.Process, err)
}

_, err = p.Exec()
err = p.Execute()
if err != nil {
log.Error("[Schedule] %s %s %s", sch.name, sch.Process, err)
}
defer p.Release()
}, nil
}

Expand Down

0 comments on commit 7bba5ea

Please sign in to comment.