-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Base Support #1150
Open
kaladinlight
wants to merge
13
commits into
trezor:master
Choose a base branch
from
kaladinlight:add-base
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Base Support #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaladinlight
force-pushed
the
add-base
branch
from
November 6, 2024 22:46
2b0aa36
to
f7b788e
Compare
kaladinlight
force-pushed
the
add-base
branch
2 times, most recently
from
December 9, 2024 22:47
f8d6461
to
64be712
Compare
kaladinlight
force-pushed
the
add-base
branch
from
January 15, 2025 22:29
5fe07ba
to
7aab656
Compare
kaladinlight
force-pushed
the
add-base
branch
from
January 21, 2025 17:42
8ab6c97
to
1254fad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Base (includes docker image backend logic from
add-arbitrum
).I also made some slight changes regarding
addrContracts
storage structure and caching. Happy to discuss this further, but it stemmed from my initial attempts at improving performance for Gnosis chain due to the large amount of spam on chain. The main bottleneck was the storing and fetching ofaddrContracts
. To help I made two changes:addressContracts
cache to be supported for both bulk connect and the regular synchronous sync modes. This allows synchronous sync to utilize the cache instead of constantly reading from db to help improve performance. There is a config flag for setting the max size of the contracts map as well for tweaking based on desired memory usage. The cache will auto prune when full prioritizing keeping the larger address contract sets considering those would take the most time to read from the db.I know this isn't really a direct requirement for Base and didn't even fully solve the Gnosis sync issues, but they still seemed like useful improvements to me, but feel free to let me know if you aren't keen about the changes and I will rip them out.