Add MarkdownFileLinks extra (#528)
#617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subclasses of LinkProcessor should specify exactly which links they want to touch, that way the link processor doesn't get run multiple times
|
Awesome, thanks for fixing the pygments error too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #528 by adding an extra that converts
.mdlinks to.htmllinks. I've also spun the link processing logic out into aLinkProcessorextra, which can be subclassed and re-used just like theItalicAndBoldProcessor.LinkProcessor
This new extra contains all of the link processing logic, allowing new extras to piggy-back off of it and manipulate links without having to re-implement the syntax matching themselves.
The class allows subclasses to filter which links they wish to process (inline/reference and anchor/image).
MarkdownFileLinks
Simply replaces
.mdlinks with.html. Also works for link definitions, although this can be turned off using the extra's options. EG:markdown(..., extras={'markdown-file-links': {'link_defs': False}})