Process HTML comments as markdown in 'escape' safe mode #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase or merge in |
Crozzers
force-pushed
the
process-escaped-html-comments
branch
from
85b4822 to
2390b87
Compare
|
Rebased onto master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the discussion in #563, this PR changes how HTML comments are dealt with when
safe_mode='escape'.Previously, HTML comments would be entirely escaped and the contents hashed to prevent further processing. Now, the comment will be detected. The opening and closing tags will be sanitised and hashed as normal but the contents of the comment will only be sanitised, not hashed. This allows for further markdown processing to happen on the comment's contents.