smoother command workflow (fixes #54) (#55)

Co-authored-by: dogi <[email protected]>

src/aws/dependencies/utilitiyFunction.sh

@@ -43,3 +43,9 @@ function makePortArray {
 
     echo "${portArray[@]}"
 }
+
+function getState(){
+    local instanceId=$1
+    local state=$(aws ec2 describe-instances --instance-ids $instanceId | jq '.Reservations[].Instances[].State.Name')
+    echo $state
+}

src/aws/down.sh

@@ -15,8 +15,8 @@ function down(){
   instanceId=$(getValueByAttribute $balloonName instanceId)
 
   if [ "$instanceId" = "null" ]; then
-      echo "$balloonName is already deleted"
-      exit 1
+      echo "$balloonName does not exist"
+      exit 0
   fi
 
   keyName=$(getValueByAttribute $balloonName key)

src/aws/start.sh

@@ -14,12 +14,24 @@ function start(){
     instanceId=$(getValueByAttribute $balloonName instanceId)
 
     if [ "$instanceId" = "null" ]; then
-        echo "$balloonName is already deleted"
+        echo "$balloonName does not exist"
         exit 1
     fi
 
     oldPublicIp=$(getValueByAttribute $balloonName publicIp)
 
+    state=$(getState $instanceId)
+
+    if [ "$state" == "\"running\"" ]; then
+        echo "The instance is already running"
+        exit 0
+    fi
+
+    if [ "$state" == "\"stopping\"" ]; then
+        echo "The instance is stopping"
+        exit 1
+    fi
+
     aws ec2 start-instances --instance-ids $instanceId
 
     echo "get the new ip address. The procedure might take time for a while"

src/aws/stop.sh

@@ -13,10 +13,16 @@ function stop(){
     instanceId=$(getValueByAttribute $balloonName instanceId)
 
     if [ "$instanceId" = "null" ]; then
-        echo "$balloonName is already deleted"
+        echo "$balloonName does not exist"
         exit 1
     fi
 
+    state=$(getState $instanceId)
+    if [[ "$state" == "\"stopped\"" || "$state" == "\"stopping\"" ]]; then
+        echo "The instance is already stopped"
+        exit 0
+    fi
+
     groupName=$(getValueByAttribute $balloonName groupName)
     storePortArrayString $groupName tcp $balloonName
     storePortArrayString $groupName udp $balloonName