Increase all plans max capacity by one #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrizor
force-pushed
the
kerrizor/increase-all-plans-max-capacity-by-one
branch
3 times, most recently
from
f034a8c
to
41a0a1a
Compare
kerrizor
commented
Dec 5, 2018
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| describe 'with a subscription on the delegatee' do | |||
| before { FactoryGirl.create(:subscription, owner: anja, selected_plan: :ten) } | |||
| it { expect(owners.max_jobs).to eq 10 } | |||
| it { expect(owners.max_jobs).to eq 11 } | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kerrizor
commented
Dec 5, 2018
| @@ -27,7 +27,7 @@ | |||
| describe 'with a subscription on both the delegatee and delegate' do | |||
| before { FactoryGirl.create(:subscription, owner: anja, selected_plan: :ten) } | |||
| before { FactoryGirl.create(:subscription, owner: travis, selected_plan: :five) } | |||
| it { expect(owners.max_jobs).to eq 15 } | |||
| it { expect(owners.max_jobs).to eq 16 } | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kerrizor
commented
Dec 5, 2018
| it { expect(selected.size).to eq 2 } | ||
| it { expect(reports).to include 'user svenfuchs capacities: public max=3, plan max=3' } | ||
| it { expect(reports).to include 'user svenfuchs plan capacity: running=1 max=3 selected=2' } | ||
| it { expect(reports).to include 'user svenfuchs: queueable=5 running=1 selected=2 total_waiting=3 waiting_for_concurrency=3' } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kerrizor
commented
Dec 5, 2018
| if sub.selected_plan && sub.owner | ||
| { plan: sub.selected_plan, owner: sub.owner } | ||
| end | ||
| }.compact |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This work is part of the "1 free private repo job" plan. https://github.com/travis-ci/product/issues/97
kerrizor
force-pushed
the
kerrizor/increase-all-plans-max-capacity-by-one
branch
from
72285ff
to
0b682ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
travis-ci/product#97