Fix windows test failures #311
Conversation
cmd/generate.go
Outdated
| @@ -31,7 +31,7 @@ func getEnvs() map[string]string { | |||
| m := make(map[string]string) | |||
|
|
|||
| for _, env := range envs { | |||
| results := strings.SplitN(env, "=", 1) | |||
There was a problem hiding this comment.
a small unittest for this would be nice
There was a problem hiding this comment.
We already have a test for this, check out the failing test for main branch
There was a problem hiding this comment.
@dennislapchenko following up on this
There was a problem hiding this comment.
Seems like this should be done with Cut, as per the docs.
https://pkg.go.dev/strings#SplitN
To split around the first instance of a separator, see Cut.
Perhaps something like:
- results := strings.SplitN(env, "=", 2)
- m[results[0]] = results[1]
+ varName, varValue, found := strings.Cut(env, "=")
+ if found {
+ m[varName] = m[varValue]
+ }There was a problem hiding this comment.
either way works, let's just go with what's already in the code and passing tests
|
@Almenon @dennislapchenko - Any update on this? This Blocks #320 |
|
I'm waiting for a review from @dmattia or others, I don't have the ability to self-merge. |
Almenon
changed the title
|
It looks like David fixed the env var parsing bug in a commit directly to master, I guess they didn't see this PR. @pseudomorph if you rebase your tests should work now. @dmattia can I get a review please? This PR used to fix the env var parsing bug and a windows bug. Now that you've fixed the first bug but this PR just fixes the windows bug, so it's a small baby-rabbit sized PR 🐰 . |
Pull Request
Related Github Issues
Description
Fix env var parsing bug