Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds basic repo boilerplate #1

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Adds basic repo boilerplate #1

merged 2 commits into from
Oct 17, 2023

Conversation

michaelfarrell76
Copy link
Member

@michaelfarrell76 michaelfarrell76 commented Oct 17, 2023 •
edited
Loading

moving over @main/change-case and createHandlebars helper so that the code can be used in the cli and the browser.

didn't want to add this to privacy-types or type-utils as those packages are so widely used - handlebars doesnt need to be used in the packages that use type-utils

@michaelfarrell76 michaelfarrell76 force-pushed the michaelfarrell76/basic-repor branch from 20fadfd to bf2e695 Compare October 17, 2023 05:43
@michaelfarrell76 michaelfarrell76 requested a review from a team October 17, 2023 05:43
@michaelfarrell76 michaelfarrell76 force-pushed the michaelfarrell76/basic-repor branch from ba43aab to 9472298 Compare October 17, 2023 05:47
@height
Copy link

height bot commented Oct 17, 2023 •
edited
Loading

This pull request has been linked to 1 task:

💡Tip: Add "Close T-30349" to the pull request title or description, to a commit message, or in a comment to mark this task as "Pending Deploy" when the pull request is merged.

dmattia
dmattia approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@dmattia dmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a plan to me. I'm familiar with the general layout of the repo and know that you are as well, so I did not review in depth but trust things can get smoothed out once the actual code is added

@michaelfarrell76
Copy link
Member Author

michaelfarrell76 commented Oct 17, 2023 •
edited
Loading

@dmattia this is just copy and pasted boilerplate from type-utils, no code yet until #1 (comment)

@michaelfarrell76 michaelfarrell76 merged commit 15ebb09 into main Oct 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the michaelfarrell76/basic-repor branch October 17, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmattia dmattia dmattia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfarrell76 @dmattia