Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to turn on autofocus #200

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

linh-transcend
Copy link
Member

@linh-transcend linh-transcend commented Dec 4, 2024

Related Issues

Security Implications

[none]

System Availability

[none]

Copy link

height bot commented Dec 4, 2024

This pull request has been linked to 1 task:

💡Tip: Add "Close T-40384" to the pull request title or description, to a commit message, or in a comment to mark this task as "Pending Deploy" when the pull request is merged.

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consent-manager-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 7:01pm

@@ -44,6 +44,7 @@ export function CompleteOptionsToggles({
consentSelection: initialConsentSelections,
defaultPurposeToMessageKey: DEFAULT_PURPOSE_TO_MESSAGE_KEY,
});
// eslint-disable-next-line react-hooks/exhaustive-deps
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why are these hooks all of a sudden got picked up by eslint for this???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just disabled the rule but lemme know if i should just add the dependencies for these hooks

Copy link
Member

@eligrey eligrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. No idea what's up with the eslint rules though

@linh-transcend linh-transcend merged commit 8379d69 into main Dec 4, 2024
11 checks passed
@linh-transcend linh-transcend deleted the linh-transcend/autofocus branch December 4, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants