Csmccarthy/intl html substitution #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Changelog
Sending in variables with the message internalization function broke the CM UI messages we were trying to display, since format.js was attempting to parse the message as rich text (there is no HTML option as far as I could tell) and encountering a parsing error due to invalid tags. i.e. was invalid because format.js can only substitute in HTML, not parse through it.
This should solve the issue by preprocessing our messages and removing HTML opening/closing tags, instead substituting them with format.js variables that we then replace during the internationalization process with the actual tags. For example:
we preprocess
Example text with a <a href="https://example.com">link</a>toExample text with a {var_to_substitute_1}link{var_to_substitute_2}and then back to the original upon callingformatMessage.