Internationalize purpose descriptions #181
Conversation
|
This pull request has been linked to 1 task:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kate-kazantseva
changed the title
package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "url": "https://github.com/transcend-io/consent-manager-ui.git" | |||
| }, | |||
| "homepage": "https://github.com/transcend-io/consent-manager-ui", | |||
| "version": "4.21.2", | |||
| "version": "4.21.3", | |||
There was a problem hiding this comment.
lets bump this a minor version, this is more than a bugfix
| return { | ||
| ...allMessages, | ||
| [purposeType]: { | ||
| id: `cm-ui.purpose.${purposeType}`, |
There was a problem hiding this comment.
oh actually i see whats going on here, nvm, we will have to split out inverted. lets make a useGetInvertedPurposeMessageKeys hook for now (in the future these should probably also be messages?)
src/messages.ts
Outdated
| @@ -456,32 +456,60 @@ export const bottomMenuMessages = defineMessages('ui.src.bottomMenu', { | |||
| }, | |||
| }); | |||
|
|
|||
| export const purposeMessages = defineMessages('purpose.trackingType', { | |||
| 'essential.title': { | |||
There was a problem hiding this comment.
| 'essential.title': { | |
| 'Essential.title': { |
these tracking types should all be pascal case, right? we switched it in the monorepo
There was a problem hiding this comment.
oh right, I need to fix this. weirdly it still worked
There was a problem hiding this comment.
yeah because the ones being displayed are overwritten successfully. if you remember when we were testing we had like Functional: undefined, p sure that was because of this
There was a problem hiding this comment.
oh, yeah I think you're right!
| return { | ||
| ...allMessages, | ||
| [purposeType]: { | ||
| id: `cm-ui.purpose.${purposeType}`, |
There was a problem hiding this comment.
oh actually i see whats going on here, nvm, we will have to split out inverted. lets make a useGetInvertedPurposeMessageKeys hook for now (in the future these should probably also be messages?)
Related Issues
Security Implications
[none]
System Availability
[none]
Kapture.2024-10-25.at.13.16.32.mp4