Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizing shadow root attachment mode #167

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

eligrey
Copy link
Member

@eligrey eligrey commented Jun 10, 2024

Related Issues

Security Implications

[none]

System Availability

[none]

@eligrey eligrey requested a review from a team June 10, 2024 21:10
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consent-manager-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 9:24pm

Copy link

height bot commented Jun 10, 2024

This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:

  • T-30929 Support loadOption for CM UI to create an 'open' shadow root instead of 'closed' shadow root (unlink task)

💡Tip: You can link multiple Height tasks to a pull request.

linh-transcend
linh-transcend previously approved these changes Jun 10, 2024
This reverts commit 24608c5.
Copy link
Member

@michaelfarrell76 michaelfarrell76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!!

@eligrey eligrey merged commit cdf3fb8 into main Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants