Add error for showConsentManager when viewState is TCF_EU
#157
Conversation
|
This pull request has been linked to 1 task:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
linh-transcend
changed the title
showConsentManager when viewState is TCF_EUshowConsentManager when viewState is TCF_EU
src/api.ts
Outdated
| return; | ||
| } | ||
| logger.warn( | ||
| 'TCF_EU view state is not valid. Please configure your regime to use this view state.', |
There was a problem hiding this comment.
| 'TCF_EU view state is not valid. Please configure your regime to use this view state.', | |
| 'TCF_EU view state is not valid for this user experience. Please configure your Regional Experience to use this view state and try again.', |
There was a problem hiding this comment.
I think we should also only throw this error for TCF_EU explicitly, and if the userpass in any other view state, we should throw a different error & log out the list of valid view states for them
There was a problem hiding this comment.
Just to confirm, if a user uses 'banana' as a view state, that's when we list out the valid view state?
There was a problem hiding this comment.
@linh-transcend yea, that's when i think we say "'${input}' is not a valid view state. Valid view states are: ..."
src/api.ts
Outdated
| options?.viewState && | ||
| !Object.values(ViewState).includes(options.viewState) | ||
| ) { | ||
| logger.warn( |
There was a problem hiding this comment.
Can we do error instead of warn?
There was a problem hiding this comment.
sorry i missed that. just updated it to an error. i need to do the same for the warning in the tcf-ui
src/api.ts
Outdated
| `${ | ||
| options.viewState | ||
| } is not a valid view state. Valid view states include ${Object.values( | ||
| ViewState, |
There was a problem hiding this comment.
@linh-transcend actually let's only list the "open" view states and not closed view states like closed/collapsed/hidden
There was a problem hiding this comment.
LanguageOptions doesn't seem right either, hmm
There was a problem hiding this comment.
I think this is the enum to use: https://github.com/transcend-io/airgap.js-types/blob/main/src/enums/viewState.ts#L64
src/settings.ts
Outdated
| @@ -63,7 +63,7 @@ const inheritLogLevels = (logLevels: LogLevel[]): LogLevel[] => { | |||
| }; | |||
|
|
|||
| const wildcardLogLevels = ['all', '*']; | |||
| const logLevelsSetting = (settings.log ?? '').toLowerCase(); | |||
| const logLevelsSetting = (settings.log ?? 'warn error').toLowerCase(); | |||
There was a problem hiding this comment.
oi i forgot to remove this from testing. thanks for catching!
delete-merged-branch
bot
deleted the
linh-transcend/invalid-view-state-error
branch
Related Issues
showConsentManagerisTCF_EUshow and error that tells the user to update regimes to see that view state. When input is not a valid view state, error too.Security Implications
[none]
System Availability
[none]