Fix event target compatibilty in Safari < 14 #155
Merged
+62
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eligrey
previously approved these changes
Jan 8, 2024
|
@eligrey ya, but i wanted to double check with you t hat this is right first before i port to the other UI! (it's a different repo) |
eligrey
reviewed
Jan 8, 2024
src/event-target.ts
Outdated
| set [Symbol.toStringTag](updatedStringTag: string) { | ||
| this.#stringTag = updatedStringTag; | ||
| } | ||
| const STRING_TAG = 'Transcend'; |
There was a problem hiding this comment.
This should be TO_STRING_TAG imo
eligrey
approved these changes
Jan 8, 2024
delete-merged-branch
bot
deleted the
anotherminh/fix-eventTarget-safari-compat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Security Implications
[none]
System Availability
[none]