create oneTrustAssessmentToJson helper

src/oneTrust/helpers/oneTrustAssessmentToJson.ts

@@ -0,0 +1,41 @@
+import { OneTrustEnrichedAssessment } from '../codecs';
+
+/**
+ * Converts the assessment into a json entry.
+ *
+ * @param param - information about the assessment and amount of entries
+ * @returns a stringified json entry ready to be appended to a file
+ */
+export const oneTrustAssessmentToJson = ({
+  assessment,
+  index,
+  total,
+}: {
+  /** The assessment to convert */
+  assessment: OneTrustEnrichedAssessment;
+  /** The position of the assessment in the final Json object */
+  index: number;
+  /** The total amount of the assessments in the final Json object */
+  total: number;
+}): string => {
+  let jsonEntry = '';
+  // start with an opening bracket
+  if (index === 0) {
+    jsonEntry = '[\n';
+  }
+
+  const stringifiedAssessment = JSON.stringify(assessment, null, 2);
+
+  // Add comma for all items except the last one
+  const comma = index < total - 1 ? ',' : '';
+
+  // write to file
+  jsonEntry = jsonEntry + stringifiedAssessment + comma;
+
+  // end with closing bracket
+  if (index === total - 1) {
+    jsonEntry += ']';
+  }
+
+  return jsonEntry;
+};

src/oneTrust/helpers/parseCliSyncOtArguments.ts

@@ -50,6 +50,7 @@ export const parseCliSyncOtArguments = (): OneTrustCliArguments => {
         `The "fileFormat" parameter must equal ${OneTrustFileFormat.Csv} when "dryRun" is "false".`,
       ),
     );
+    return process.exit(1);
   }
 
   // If trying to sync to disk, must specify a file path

src/oneTrust/helpers/syncOneTrustAssessments.ts

@@ -81,6 +81,7 @@ export const syncOneTrustAssessments = async ({
       riskDetails,
     });
 
+    // sync to file
     if (dryRun && file && fileFormat) {
       writeOneTrustAssessment({
         assessment: enrichedAssessment,

src/oneTrust/helpers/writeOneTrustAssessment.ts

@@ -7,6 +7,7 @@ import { DEFAULT_ONE_TRUST_ASSESSMENT_CSV_HEADER } from '../constants';
 import { decodeCodec } from '@transcend-io/type-utils';
 import { OneTrustAssessmentCsvRecord } from '@transcend-io/privacy-types';
 import { OneTrustEnrichedAssessment } from '../codecs';
+import { oneTrustAssessmentToJson } from './oneTrustAssessmentToJson';
 
 /**
  * Write the assessment to disk at the specified file path.
@@ -42,23 +43,12 @@ export const writeOneTrustAssessment = ({
 
   // For json format
   if (fileFormat === OneTrustFileFormat.Json) {
-    // start with an opening bracket
-    if (index === 0) {
-      fs.writeFileSync(file, '[\n');
-    }
-
-    const stringifiedAssessment = JSON.stringify(assessment, null, 2);
-
-    // Add comma for all items except the last one
-    const comma = index < total - 1 ? ',' : '';
-
-    // write to file
-    fs.appendFileSync(file, stringifiedAssessment + comma);
-
-    // end with closing bracket
-    if (index === total - 1) {
-      fs.appendFileSync(file, ']');
-    }
+    const jsonEntry = oneTrustAssessmentToJson({
+      assessment,
+      index,
+      total,
+    });
+    fs.appendFileSync(file, jsonEntry);
   } else if (fileFormat === OneTrustFileFormat.Csv) {
     const csvRows = [];