Add llm add install test (#193)

* fix install * fix install * fix install --------- Co-authored-by: Gaurav - Personal <[email protected]>
trane-dev · Mar 30, 2024 · 3d74335 · 3d74335
1 parent c7e9c33
commit 3d74335
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/install.yaml b/.github/workflows/install.yaml
@@ -31,3 +31,9 @@ jobs:
       - name: Check package conflicts
         run: |
           python -m pip check
+      - name: Install add ons
+        run: |
+          python -m pip install "unpacked_sdist/[llm]"
+      - name: Test by importing packages
+        run: |
+          python -c "import openai"
diff --git a/.github/workflows/test_without_dev_deps.yaml b/.github/workflows/test_without_dev_deps.yaml
@@ -41,3 +41,6 @@ jobs:
           print(problems[39])
           print(problems[0].create_target_values(data).head(5))
         shell: python
+      - name: Build llm add-on
+        run: |
+          python -m pip install unpacked_sdist/[llm]
diff --git a/README.md b/README.md
@@ -63,7 +63,7 @@ For each <location> predict if there exists a record with <rating> equal to <str
 For each <location> predict if there exists a record with <rating> not equal to <str>
 ```
 
-With Trane's LLM add-on (`pip install trane[llm]`), we can determine the relevant problems with OpenAI:
+With Trane's LLM add-on (`pip install "trane[llm]"`), we can determine the relevant problems with OpenAI:
 ```python
 from trane.llm import analyze
 

diff --git a/trane/llm/helpers.py b/trane/llm/helpers.py
@@ -6,7 +6,6 @@
 
 openai = import_or_none("openai")
 tiktoken = import_or_none("tiktoken")
-anthropic = import_or_none("anthropic")
 ipython = import_or_none("IPython")